Clarify datatype of parameters in JSON files #1970
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request tries to make the JSON parameter file values of
integer_value
andboolean_value
less confusing.Now, a boolean parameter has
integer_value
false andboolean_value
true.And an integer parameter has
integer_value
true andboolean_value
false.And a float parameter has
integer_value
false andboolean_value
false.The Tax-Calculator tests have been changed to enforce this new approach and the source code has been modified to handle the new pattern of values.
These changes do imply a change in the user documentation, but they cause no changes in test results or calculated tax results.
Thanks to @hdoupe for pointing out the need for these changes in his extensive work on pull request #1952.